Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies: testcontainers & wiremock-go + Test against multiple recent Golang versions #37

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Update dependencies: testcontainers & wiremock-go + Test against multiple recent Golang versions #37

merged 1 commit into from
Feb 22, 2024
+442 −299

Conversation

AntoniKania
Copy link
Contributor

References

Direct dependencies updated:
testcontainers-go | v0.22.0 => v0.28.0
go-wiremock | v1.7.1 => v1.8.0
go-connections | v0.4.0 => v0.5.0

I've also changed the minimal required version of go to the 1.20, as the new version of testcontainers-go specifies this version. Docs that were specified the minimal version as 1.19 were also updated

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

jamietanna
jamietanna approved these changes Feb 17, 2024
View reviewed changes
Copy link
Contributor

@jamietanna jamietanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have commit access to this repo - but have some on the core Wiremock repo - and approve these changes.

The bump to Go 1.20 is required - to keep in line with the upstream requirement as you mention - and good that we're keeping vaguely in-date with Go versions.

I'd recommend us follow-up by testing against multiple versions (i.e. https://github.com/oapi-codegen/runtime/blob/1f1f11683f267893a4f7b2ab3c7ae000637e27ea/.github/workflows/ci.yml#L7-L22) to make sure that we're keeping support for newer versions of Go, too.

It may also be worth us making sure that the examples use replace directives to allow us to point to the current source checkout for the project, rather than pinning to whatever the latest released tag is, but that comes with a teency bit more complexity in your builds.

@jamietanna
Copy link
Contributor

I'd also recommend this is merged as a chore 👍

@AntoniKania AntoniKania force-pushed the noissue/update-dependecies branch from 47c0a5a to 8868480 Compare February 17, 2024 17:24
@AntoniKania
Copy link
Contributor Author

Thanks for insightful comments and suggestions with sources!
I've applied the changes with CI/CD pipeline in this commit, and added the chore: prefix to the commit message.
I didn't quite get the suggestion with replace directives. Currently we are using them in two directories under the examples directory (here and here), so that test files there could use the currently checkout code. Isn't it what you meant by your comment?

@oleg-nenashev oleg-nenashev changed the title Update dependencies: testcontainers & wiremock-go Update dependencies: testcontainers & wiremock-go + Test against multiple recent Golang versions Feb 22, 2024
@oleg-nenashev oleg-nenashev added the chore Maintenance label Feb 22, 2024
@oleg-nenashev oleg-nenashev merged commit f11e8f1 into wiremock:main Feb 22, 2024
3 checks passed
@jamietanna
Copy link
Contributor

Ah @AntoniKania I didn't mean for you to solve those additional things in this PR, was me talking out loud while I thought of it - appreciate the changes you did make!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamietanna jamietanna jamietanna approved these changes

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
chore Maintenance dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntoniKania @jamietanna @oleg-nenashev